Clean up return types#310
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #310 +/- ##
=======================================
Coverage 89.73% 89.73%
=======================================
Files 22 22
Lines 3263 3263
=======================================
Hits 2928 2928
Misses 335 335
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dumbbell
force-pushed
the
cleanup-return-types
branch
from
c973942 to
10ad873
Compare
the-mikedavis
approved these changes
Dec 13, 2024
[Why] `khepri_machine:common_ret()` and `khepri_adv:many_results()` were synonyms. With the removal of `khepri_adv:single_result()`, the distinction becomes irrelevant: we don't need `khepri_adv:many_results()` is now useless. Also, the name `khepri_machine:common_ret()` didn't mean much because it is only used by few functions. [How] `khepri_machine:common_ret()` is renamed to `khepri_machine:write_ret()` and the `khepri_adv:many_results()` alias is removed. While here, move `khepri_adv:node_props_map()` to `khepri`.
dumbbell
force-pushed
the
cleanup-return-types
branch
from
10ad873 to
2fb4110
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
khepri_machine:common_ret()andkhepri_adv:many_results()were synonyms. With the removal ofkhepri_adv:single_result(), the distinction becomes irrelevant: we don't needkhepri_adv:many_results()is now useless.Also, the name
khepri_machine:common_ret()didn't mean much because it is only used by few functions.How
khepri_machine:common_ret()is renamed tokhepri_machine:write_ret()and thekhepri_adv:many_results()alias is removed.While here, move
khepri_adv:node_props_map()tokhepri.