Skip to content

Restore flake8 test#244

Merged
Gsantomaggio merged 4 commits intomasterfrom
feat/restore_checks
Sep 22, 2025
Merged

Restore flake8 test#244
Gsantomaggio merged 4 commits intomasterfrom
feat/restore_checks

Conversation

@Gsantomaggio
Copy link
Copy Markdown
Member

@Gsantomaggio Gsantomaggio commented Sep 22, 2025

This PR restores the flake8 linting test in the CI workflow and fixes various linting issues that were identified by flake8.

  • Uncommented the flake8 test in the GitHub Actions workflow
  • Cleaned up unused variables and imports across test files
  • Fixed incorrect string encoding in AMQP message bodies

Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio Gsantomaggio added this to the 0.4.0 milestone Sep 22, 2025
Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restores the flake8 linting test in the CI workflow and fixes various linting issues that were identified by flake8.

  • Uncommented the flake8 test in the GitHub Actions workflow
  • Cleaned up unused variables and imports across test files
  • Fixed incorrect string encoding in AMQP message bodies

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/test.yaml Restored flake8 linting step and updated RabbitMQ image version
tests/test_consumer.py Removed unused variable declarations and fixed string encoding issues
tests/test_producer.py Removed unused variable declaration
tests/test_amqp.py Removed unused pytest_asyncio import
tests/conftest.py Removed unused pytest import and added super stream cleanup

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread tests/conftest.py
Comment on lines +162 to +164
except Exception:
# it doesn't matter if it fails
pass
Copy link

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Catching bare Exception is too broad and can hide unexpected errors. Consider catching more specific exceptions or at least logging the exception for debugging purposes.

Suggested change
except Exception:
# it doesn't matter if it fails
pass
except Exception as e:
# it doesn't matter if it fails, but log for debugging
logging.warning(f"Failed to delete super stream 'test-super-stream': {e}")

Copilot uses AI. Check for mistakes.
@Gsantomaggio Gsantomaggio marked this pull request as ready for review September 22, 2025 15:56
@Gsantomaggio Gsantomaggio self-assigned this Sep 22, 2025
@Gsantomaggio Gsantomaggio merged commit b746571 into master Sep 22, 2025
1 check passed
@Gsantomaggio Gsantomaggio deleted the feat/restore_checks branch September 22, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants