Restore flake8 test#244
Merged
Gsantomaggio merged 4 commits intomasterfrom Sep 22, 2025
Merged
Conversation
Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR restores the flake8 linting test in the CI workflow and fixes various linting issues that were identified by flake8.
- Uncommented the flake8 test in the GitHub Actions workflow
- Cleaned up unused variables and imports across test files
- Fixed incorrect string encoding in AMQP message bodies
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/test.yaml | Restored flake8 linting step and updated RabbitMQ image version |
| tests/test_consumer.py | Removed unused variable declarations and fixed string encoding issues |
| tests/test_producer.py | Removed unused variable declaration |
| tests/test_amqp.py | Removed unused pytest_asyncio import |
| tests/conftest.py | Removed unused pytest import and added super stream cleanup |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+162
to
+164
| except Exception: | ||
| # it doesn't matter if it fails | ||
| pass |
There was a problem hiding this comment.
Catching bare Exception is too broad and can hide unexpected errors. Consider catching more specific exceptions or at least logging the exception for debugging purposes.
Suggested change
| except Exception: | |
| # it doesn't matter if it fails | |
| pass | |
| except Exception as e: | |
| # it doesn't matter if it fails, but log for debugging | |
| logging.warning(f"Failed to delete super stream 'test-super-stream': {e}") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restores the flake8 linting test in the CI workflow and fixes various linting issues that were identified by flake8.