-
Notifications
You must be signed in to change notification settings - Fork 71
Replace pkg_resources to importlib.resources #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Replace pkg_resources to importlib.resources #136
Conversation
**Note this change make it unavailable on python<3.9.** - Use `importlib.resources` instead of `pkg_resources`. - In `example_label_file`, the argument `phone_level` must be assigned using a keyword name.
python3.2 以降で `assertRaisesRegexp` -> `assertRaisesRegex` に変更されているため修正。
|
Thank you! Can you update github actions settings to drop python 3.9 and add 3.12 instead? |
|
Thank you for checking!
Sure, I'll try that.
|
|
looks like lint is failing. can you fix it? I'll triger CI again later |
|
OK, checking now |
|
Fixed import sort, to fix the isort linting error. |
|
https://github.com/r9y9/nnmnkwii/actions/runs/17978488176/job/51140647384?pr=136 looks like CI still complains about linting issues |
windows python312 を削除 (pysen のうち flake8 がうまく動かない模様)
- Fixed error `TypeError: 'nnmnkwii.util.files' is not a package`
|
On python312, This pysen's error is expected to be come from the flake8 incompatibility. I have no good ideas for now. Error log of |
|
Newer pysen and flake8>=6.1.0 might solve these problems. |
Fix #135
pkg_resourcestoimportlib.resources, in order to use nnmnkwii even after 2025-11-30 with the latest setuptools>=81.importlib.resources.filesis available only in Python>=3.9.assertRaisesRegexp->assertRaisesRegex