chore: substitute AccountKeyring with Sr25519Keyring#519
Merged
al3mart merged 1 commit intoal3mart/sync-polkadot-stable2503from Apr 27, 2025
Merged
chore: substitute AccountKeyring with Sr25519Keyring#519al3mart merged 1 commit intoal3mart/sync-polkadot-stable2503from
AccountKeyring with Sr25519Keyring#519al3mart merged 1 commit intoal3mart/sync-polkadot-stable2503from
Conversation
30 tasks
Contributor
|
Quick question: I am a bit out of context so curious, in the linked issue replaces |
Member
Author
The linked PR is even called |
Contributor
Ah my bad 😅 CI is failing, can approve when it's fixed |
Member
Author
I'm afraid we will only see a green CI on the base PR. I've pushed the version bump to the branch this one is based on. Meaning that to compile the node we not only need this change in, but many others that will go into the base branch. I think at this point we should approve if these individual PRs if they are in line with their corresponding changes upstream. |
al3mart
merged commit 07b495a
into
al3mart/sync-polkadot-stable2503
2 of 15 checks passed
al3mart
added a commit
that referenced
this pull request
Apr 30, 2025
chore: substitute AccountKeyring with Sr25519Keyring
al3mart
added a commit
that referenced
this pull request
May 5, 2025
chore: substitute AccountKeyring with Sr25519Keyring
evilrobot-01
pushed a commit
that referenced
this pull request
May 7, 2025
* chore: update lock file after rebase * refactor: update DryRunApi::dry_run_call * chore: `BlockNumberProvider` for multisig, nfts & proxy (#517) chore: add BlockNumberProvider for multisig, nfts & proxy * chore: substitute `AccountKeyring` with `Sr25519Keyring` (#519) chore: substitute AccountKeyring with Sr25519Keyring * chore: weight for `pallet_utility` `if_else` extrinsic (#521) chore: weight for pallet_utility::if_else extrinsic * fix: version conversion in `XcmPaymentApi::query_weight_to_asset_fee` (#523) chore: fix version conversion in query_weight_to_asset_fee * chore: update `eth_transact` and `bare_eth_transact` apis (#524) chore: update eth_transact and bare_eth_transact * chore: impl `EthGasEncoder` for `pallet_revive` (#525) chore: impl EthGasEncoder for pallet_revive * chore: change toolchain to wasm32v1-none (#531) * refactor: remove dependencies on `sp-std` (#533) * chore: use alloc::vec::Vec * refactor(api): reorg imports * refactor: remove depencency on sp-std * chore(revive): remove Debug buffer and add tracing support (#529) * chore: sdk-7163 * chore: sdk-7166 * chore: sdk-7167 * feat: implement `ReviveApi::block_gas_limit` api (#537) feat(revive-api): implement block_gas_limit api * chore(revive): implement FindAuthor (#530) changes after rebase * docs: note required missing revive migration for testnet (#534) docs: note required missing migration testnet deployment * feat(xcm): implement XcmEventEmitter (#535) * chore: add `BlockNumberProvider` to `pallet_scheduler` (#518) chore: add BlockNumberProvider for pallet_scheduler * feat(session): implement `DisablingStrategy` (#538) feat(session): implement DisablingStrategy * chore: weights for `pallet_multisig::poke_deposit` (#539) chore: weights for pallet_multisig::poke_deposit * chore: weights for `pallet_proxy::pole_deposit` (#540) chore: weights for pallet_proxy::pole_deposit * refactor(xcm-weights): `initiate_transfer` always charges base weight (#541) refactor: initiate_transfer always charges base weight * feat: implement pallet view functions (#542) * chore: impl `Holder` for `pallet_assets` (#543) chore: impl Holder for pallet_assets * refactor: remove unnecessary `network_starter` (#544) refactor: remove network_starter * chore: add `max_pov_percentage` to `AuraParams` (#545) chore: add max_pov_percentage to AuraParams * chore: Configurable number of genesis accounts in pallet_balances (#520) * chore: Configurable number of genesis accounts in pallet_balances * chore(integration-tests): include missing genesis config for balances * refactor: StorageWeightReclaim as wrapping transaction extension (#546) * feat(xcm): authorized aliasers for devnet & testnet * chore: update missing weights * chore: weights for pallet_utility::dispatch_as_fallible * refactor: derive `DecodeWithMemTracking` (#536) * refactor: derive DecodeWithMemTracking for ProxyType * refactor: derive DecodeWithMemTracking in pallets structs * refactor: impl DecodeWithMemTracking for ItemSettings & CollectionSettings * chore: update revive weights * chore: AuthorizedAliaserHoldReason * chore(xcm): group parameter_types * refactor: move DepositPerByte & DepositPerItem to pop_common * style: typo * chore: bump dependencies * revert chain change in network/devnet.toml * refactor(motion): don't derive DecodeWithMemTracking within tests * refactor(nfts): don't derive DecodeWithMemTracking for OldCollectionDetails * chore: further minor fixes * chore: further fixes * typo * refactor: remove derivation of DecodeWithMemTracking from tests * fix: missing imports * fix: missing genesis dev_accounts config * refactor: reorg imports * fix: missing balances geneisis dev_accounts config in extension mock * rebase changes * chore: bump frame-metadata version * chore: update Cargo.lock * chore: update Cargo.lock * chore: update contracts lock files * chore(ci): add stable-x86_64 toolchain for api-integration-tests * chore(ci): ass stable-x86_64-unknown-linux-gnu for llvm-tools-preview * chore:(ci): add rustc toolchain stable-x86_64-unknown-linux-gnu * fix(ci): add components to rust-toolchain * style: fmt rust-toolchain * test(mainnet): update apis::metadata_api_implemented * ci: print versions * ci: temporarily deactivate runtime-benchmarks feat from * chore: rebase to main - include revive in devnet * chore: missing updates for non-sdk dependencies * fix: amend devnet zn network spec regression * test(mainnet): more explicit tests * feat(testnet): add pallet_migrations & Reset pallet_revive * docs(ci): clarify jobs in which restore runtime-benchmarks feat * chore(apis): sync ReviveApi::trace_call impl with upstream reference * chore: include missing migrations * fix: missing propagation of try-runtime for pallet-migrations * chore: #[allow(non_local_definitions)] for Benchmark::dispatch_benchmark & clean imports * chore: use build_struct_json_patch to build genesis config patch
chungquantin
pushed a commit
that referenced
this pull request
May 7, 2025
chore: substitute AccountKeyring with Sr25519Keyring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per polkadot-sdk#5899.
This PR substitutes all occurrences of
AccountKeyringwithSr25519Keyring.[sc-3547]