Merged
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #516 +/- ##
==========================================
- Coverage 64.43% 64.07% -0.36%
==========================================
Files 124 124
Lines 23325 23456 +131
Branches 23325 23456 +131
==========================================
Hits 15029 15029
- Misses 7637 7768 +131
Partials 659 659
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new "revive" feature for the devnet runtime. Key changes include:
- Adding new imports and definitions for pallet_revive in the runtime library.
- Implementing EthExtra and the ReviveApi trait for EVM transaction handling.
- Updating contract configuration and workspace settings to support the revive pallet.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| runtime/devnet/src/lib.rs | Introduces new types, traits, and API implementations for revive. |
| runtime/devnet/src/config/contracts.rs | Updates contract configuration to integrate the revive pallet. |
| runtime/devnet/Cargo.toml | Adds revive pallet to the workspace and benchmarking targets. |
evilrobot-01
requested changes
Apr 28, 2025
Collaborator
evilrobot-01
left a comment
There was a problem hiding this comment.
Looks good, just two things which I think could be improved easily and therefore worth the minimal effort.
* refactor(devnet): update contracts config to use chain id from genesis * refactor(devnet): update contracts config to align code hash lockup deposit percent with mainnet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds revive to the devnet runtime.
This is to ensure devs can deploy revive contracts on a local devnet.
Consider the upcoming PRs:
eth_transactandbare_eth_transactapis #524EthGasEncoderforpallet_revive#525includes removal of pallet contracts)