Skip to content

feat(devnet): revive#516

Merged
evilrobot-01 merged 2 commits intomainfrom
daan/chore-devnet_revive
May 5, 2025
Merged

feat(devnet): revive#516
evilrobot-01 merged 2 commits intomainfrom
daan/chore-devnet_revive

Conversation

@Daanvdplas
Copy link
Copy Markdown
Collaborator

@Daanvdplas Daanvdplas commented Apr 23, 2025

Adds revive to the devnet runtime.

This is to ensure devs can deploy revive contracts on a local devnet.

Consider the upcoming PRs:

@Daanvdplas Daanvdplas changed the title feat: revive feat(devnet): revive Apr 23, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 131 lines in your changes missing coverage. Please review.

Project coverage is 64.07%. Comparing base (27f09da) to head (2a3bdce).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
runtime/devnet/src/lib.rs 0.00% 126 Missing ⚠️
runtime/devnet/src/config/contracts.rs 0.00% 5 Missing ⚠️
@@            Coverage Diff             @@
##             main     #516      +/-   ##
==========================================
- Coverage   64.43%   64.07%   -0.36%     
==========================================
  Files         124      124              
  Lines       23325    23456     +131     
  Branches    23325    23456     +131     
==========================================
  Hits        15029    15029              
- Misses       7637     7768     +131     
  Partials      659      659              
Files with missing lines Coverage Δ
runtime/devnet/src/config/contracts.rs 66.66% <0.00%> (-17.55%) ⬇️
runtime/devnet/src/lib.rs 4.27% <0.00%> (-1.18%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Daanvdplas Daanvdplas requested review from a team and Copilot April 23, 2025 15:14
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new "revive" feature for the devnet runtime. Key changes include:

  • Adding new imports and definitions for pallet_revive in the runtime library.
  • Implementing EthExtra and the ReviveApi trait for EVM transaction handling.
  • Updating contract configuration and workspace settings to support the revive pallet.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
runtime/devnet/src/lib.rs Introduces new types, traits, and API implementations for revive.
runtime/devnet/src/config/contracts.rs Updates contract configuration to integrate the revive pallet.
runtime/devnet/Cargo.toml Adds revive pallet to the workspace and benchmarking targets.

Copy link
Copy Markdown
Collaborator

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two things which I think could be improved easily and therefore worth the minimal effort.

* refactor(devnet): update contracts config to use chain id from genesis

* refactor(devnet): update contracts config to align code hash lockup deposit percent with mainnet
@evilrobot-01 evilrobot-01 enabled auto-merge (squash) May 5, 2025 07:40
@evilrobot-01 evilrobot-01 self-requested a review May 5, 2025 07:42
Copy link
Copy Markdown
Collaborator

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@al3mart al3mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@evilrobot-01 evilrobot-01 merged commit 89f2866 into main May 5, 2025
17 checks passed
@evilrobot-01 evilrobot-01 deleted the daan/chore-devnet_revive branch May 5, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants