-
Notifications
You must be signed in to change notification settings - Fork 40
feat: Allow sourcing plain files (not just binaries) and remove Paseo chain specs generator in favor of chain specs #783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…-generator-for-paseo
…-generator-for-paseo
…-generator-for-paseo
|
Some IDs aren't correct on Paseo last release's chain specs. Namely BridgeHub, People, Collectives and Coretime have a wrong ID and cannot be used to launch a network using This is already addressed here and will be included in next release, so just be aware of it til that release is out. This also will make the CI fails cause this test cannot pass until Paseo 2.0.2 is out. That's why I'm directly using 2.0.2 as fallback even if it's not out yet. |
|
@AlexD10S mind to add copilot as a reviewer? Don't know why I can't 😢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR extends the caching and sourcing capabilities of pop to support plain files (not just binaries) and migrates Paseo chain specifications from using a generator to pre-built chain spec files hosted in the paseo-network/runtimes repository.
Key changes:
- Introduces
ArchiveTypeenum (Binary|File) to differentiate between executable binaries and plain files - Renames
BinarytoSourcedArchiveto better reflect that it can now handle both binaries and files - Adds
chain_spec_file()function to source chain spec JSON files directly from releases - Updates Paseo runtime sourcing from
r0gue-io/paseo-runtimes(chain spec generator) topaseo-network/runtimes(pre-built specs) with fallback versionv2.0.2 - Adapts path construction logic to handle file extensions when versioning (e.g.,
paseo-local-v2.0.2.json)
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/pop-common/src/sourcing/archive.rs | Renamed from binary.rs; adds ArchiveType and file path handling logic |
| crates/pop-common/src/sourcing/mod.rs | Updates sourcing functions to handle files; adds file download without executable permissions |
| crates/pop-common/src/errors.rs | Adds StrumPropertyError for better trait error handling |
| crates/pop-chains/src/up/chain_specs.rs | Adds chain_spec_file() function; updates Paseo to use file-based specs |
| crates/pop-chains/src/up/relay.rs | Integrates chain_spec_file alongside chain_spec_generator |
| crates/pop-chains/src/up/mod.rs | Adds chain_spec_file field to RelayChain and Chain structs; renames binaries() to archives() |
| crates/pop-cli/src/commands/up/network.rs | Updates terminology from "binaries" to "archives" in user-facing messages |
| All test files | Updates test assertions to check ArchiveType and verify file sourcing behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…-spec-generator-for-paseo
dc4ce12 to
ed4bf96
Compare
ed4bf96 to
fa66c94
Compare
Closes:
By:
popand might be used by other features in the future.popversions).