Merged
Conversation
al3mart
approved these changes
Aug 26, 2024
Member
al3mart
left a comment
al3mart
left a comment
There was a problem hiding this comment.
Every change that seems necessary is included 👍
Approving as the code works perfectly fine.
Only thing from my side would be that I would vote for rolling back the refactor on the constants naming. Not separating the prefixes, but separating only whole words :)
al3mart
approved these changes
Sep 17, 2024
This was referenced Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status: ✅ Compiled and built successfully
Release: https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-stable2407-1, https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-stable2407
Compare Parachain Template (v1.14.0) vs Parachain Template (stable2407)
Direct changes
BadOriginfromsp_runtime