Skip to content

Fix unnecessary error on failure to parse headers$Date#529

Closed
stefanfritsch wants to merge 1 commit intor-lib:masterfrom
stefanfritsch:master
Closed

Fix unnecessary error on failure to parse headers$Date#529
stefanfritsch wants to merge 1 commit intor-lib:masterfrom
stefanfritsch:master

Conversation

@stefanfritsch
Copy link
Copy Markdown

Hi,

when parsing the headers$Date in request_perform fails, e.g. because the response is not in en_US it results in an unhelpful prettyNum (or so) error.

I just split the if-else to replace the date with something valid if it failed to parse.

Ciao,
Stefan

@hadley
Copy link
Copy Markdown
Member

hadley commented Nov 22, 2018

Could you please give me an example of the error that this resolves? I don't understand what you mean by prettyNum

@hadley
Copy link
Copy Markdown
Member

hadley commented Nov 22, 2018

Oh I see this is a duplicate of #544, which explains the problem better.

@hadley hadley closed this Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants