Change default precision for POST requests#490
Merged
hadley merged 5 commits intor-lib:masterfrom Dec 4, 2018
Merged
Conversation
Member
|
Thanks - this seems like a reasonable change to me. Can you please add a bullet to NEWS? It should briefly describe the change and end with |
Member
|
Thanks @jmwerner! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! This PR was inspired by losing decimal precision via a POST request, e.g.
This is happening because of the default
jsonlite::toJSONbehavior which can be easily fixed by passing a json tobodyin lieu of this PR if the dev team believes the default behavior should not be changed.Please let me know if any changes are necessary. Thanks!