Closed
Conversation
jennybc
commented
Feb 22, 2023
Comment on lines
+99
to
+104
| #' `gargle_oauth_client_type()` returns the option named | ||
| #' "gargle_oauth_client_type", if defined. If defined, the option must be either | ||
| #' "installed" or "web". If the option is not defined, the function returns: | ||
| #' * "web" on RStudio Server, Posit Workbench, Posit Cloud, or Google | ||
| #' Colaboratory | ||
| #' * "installed" otherwise |
Member
Author
There was a problem hiding this comment.
Why is this rigged differently from gargle_oob_default(), where we impose our own logic before consulting an option? Here we first consult the option and impose our own logic if the option is undefined.
Because it seems like we must do some form of OOB auth on RStudio Server, Posit Workbench, Posit Cloud, or Google Colab. Starting a local webserver will never make sense in this context.
Whereas, once we know we're doing some form of OOB, the client type determines whether it's conventional OOB ("installed" client type) or pseudo-OOB ("web" client type). I expect conventional OOB to be relatively rare these days, but it is still possible.
This was referenced Apr 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #140