Skip to content

Simplify looks_different()#247

Merged
hadley merged 1 commit intomainfrom
looks-different
Jun 17, 2025
Merged

Simplify looks_different()#247
hadley merged 1 commit intomainfrom
looks-different

Conversation

@hadley
Copy link
Copy Markdown
Member

@hadley hadley commented Jun 16, 2025

No description provided.

@hadley hadley requested a review from cderv June 16, 2025 18:50
@cderv cderv mentioned this pull request Jun 17, 2025
cderv

This comment was marked as duplicate.

Copy link
Copy Markdown
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is valid change and easier to understand as %is_prefix_of% is covering all other checks

It still does not fix the problem are identical display list will be filtered out

@hadley hadley merged commit c744a58 into main Jun 17, 2025
14 checks passed
@hadley hadley deleted the looks-different branch June 17, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants