Fix warnings about non_local_definitions#31
Merged
quodlibetor merged 2 commits intoquodlibetor:mainfrom Apr 19, 2024
Merged
Conversation
|
Hi @quodlibetor, any chance this could be merged any soon? |
Owner
|
ah thanks for the ping! And for the fix! yeah I'll get this out. |
Owner
|
this is released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes named constant block to anon-const so rustc doesn't warn about
non_local_definitions(and makes minor fixes suggested by clippy)Details:
Recent nightly versions implement rust-lang/rust#120393 which causes compilation warnings like
As warning states, this lint might become
deny-by-defaultin the future.Only exception to this rule are anon-const which are used also by
serdeto be compatible with different rust editions more info here.