Open
Conversation
Contributor
Glacialte
commented
Feb 10, 2026
Glacialte
commented
- 誤差逆伝搬の実装+テスト追加
- PauliOperator::get_expectation_valueのテスト追加
- Operator::get_expectation_values追加＋テスト追加
… into 289-add-backprop-subbranch
Glacialte
requested review from
KowerKoint and
gandalfr-KY
and removed request for
gandalfr-KY
Contributor
Author
Contributor
|
あんまり自信ないんですけど入力の演算子がエルミートであることを仮定してる気がします？ |
Contributor
|
もし実装するなら演算子を実部と虚部に分けて2回backpropを呼ぶか，あるいは内部で3本のベクトルを更新することでできそうですね． |
Contributor
|
また，関数名がbackpropでよいのかについては考えたいです．何が返るかの情報がなく，計算手法のみが伝わる名前になっているのが気になってます |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.