Skip to content

fix(Story Element): Replaced all Anchor tags to open in new tab #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nandakumargm merged 3 commits into from
Jan 4, 2019
Merged

fix(Story Element): Replaced all Anchor tags to open in new tab #65

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7cf5092
Fix(Story Element): Replaced all Anchor tags to open in new tab
nandakumargm Jan 4, 2019
5d93328
fix(Story Element): Shorten code
nandakumargm Jan 4, 2019
f7b1c14
Fix(Story Element): Quote change
nandakumargm Jan 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/components/story-element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,12 @@ import Polltype from './story-elements/polltype';
import {Table} from './story-elements/table';
import { Link } from './link';

function StoryElementText({element}) {
return React.createElement("div", {dangerouslySetInnerHTML: {__html: element.text}});
function StoryElementText({element = {},externalLink}) {
let text = element.text || '';
if(externalLink){
text = element.text.replace(/<a/g,"<a target='_blank'");
Copy link
Contributor

@Jeevan-Kishore Jeevan-Kishore Jan 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"<a target='_blank'", should be '<a target="_blank"'

}
return React.createElement("div", {dangerouslySetInnerHTML: {__html: text}});
}

function StoryElementAlsoRead({element, story}) {
Expand Down