feat(ssoLogin): Adding paths for sso server side logins#114
Merged
nandap4790 merged 27 commits intomasterfrom Mar 20, 2020
Merged
feat(ssoLogin): Adding paths for sso server side logins#114nandap4790 merged 27 commits intomasterfrom
nandap4790 merged 27 commits intomasterfrom
Conversation
sharangj
commented
Feb 13, 2020
| constructor(props) { | ||
| super(props); | ||
| this.serverSideLoginPath = `/login?auth-provider=${this.props.provider}&remote-host=${global.location && global.location.origin}`; | ||
| this.serverSideLoginPath = `/sign-in-page?auth-provider=${this.props.provider}&remote-host=${global.location && global.location.origin}`; |
Contributor
Author
There was a problem hiding this comment.
Dont change the current serverSideLoginPath. This will break other logins.
| super(props); | ||
| this.serverSideLoginPath = `/login?auth-provider=${this.props.provider}&remote-host=${global.location && global.location.origin}`; | ||
| this.serverSideLoginPath = `/sign-in-page?auth-provider=${this.props.provider}&remote-host=${global.location && global.location.origin}`; | ||
| this.serverSideSSOLoginPath = `/sign-in-page?auth-provider=${this.props.provider}&redirect-url=${this.props.sso && this.props.redirectUrl ? this.props.redirectUrl : global.location && global.location.origin}`; |
Contributor
Author
There was a problem hiding this comment.
Isnt this "/login?auth-provider=facebook". This is what log the person in to sketches.
sharangj
commented
Mar 20, 2020
.babelrc
Outdated
| ], | ||
| env: { | ||
| test: { | ||
| plugins: ['dynamic-import-node'] |
package.json
Outdated
| "babel-eslint": "^10.0.3", | ||
| "babel-jest": "^24.8.0", | ||
| "babel-plugin-annotate-pure-calls": "^0.4.0", | ||
| "babel-plugin-dynamic-import-node": "^2.3.0", |
2. Update package and package lock
nandap4790
approved these changes
Mar 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#113