Conversation
Contributor
|
What is this for? What does it do? |
gja
suggested changes
Aug 26, 2019
Contributor
gja
left a comment
There was a problem hiding this comment.
Please add documentation and an example.
Contributor
|
@chchitti please update the README.md explaining how to use your new options |
2d45d8f to
d0d62d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The context is for some publishers, in the story pages after the story we are showing a set of story snapshots created using stories fetched from InfiniteStoryPage component. The InfiniteStoryPage Component will set the url to the next story when the next story comes into focus. When the snapshot loads, the url is changed to the next story url by the InfiniteStoryPage component and we want to make this tog gable.
Example:
<InfiniteStoryBase
render={this.getStoryTemplate()}
loadItems={this.storyPageLoadItems}
onInitialItemFocus={item => this.onInitialItemFocusHandler(item)}
onItemFocus={() =>{}}
doNotChangeUrl={true} />
This will disable updating of url and title of the page when the next story loads