Enabling Render prop for New story Elements (Gulf) based on Card attribute#468
Open
VeenaYemmiganur wants to merge 56 commits intomasterfrom
Open
Enabling Render prop for New story Elements (Gulf) based on Card attribute#468VeenaYemmiganur wants to merge 56 commits intomasterfrom
VeenaYemmiganur wants to merge 56 commits intomasterfrom
Conversation
ags1773
reviewed
Jul 25, 2024
| export const FullStoryContent = ({ story }) => { | ||
| export const FullStoryContent = ({ story, config }) => { | ||
| return story.cards.map((card, cardIdx) => { | ||
| const customCardRender = get(config, ["opts", "render", "storyCardRenderProps"], {}); |
Contributor
There was a problem hiding this comment.
rename to storyCardRender since we're following the same convention elsewhere in amplib
…For LiveBlog Template
…uintype-amp into also-in-package-story-element
…o also-in-package-story-element
Jeevan-Kishore
suggested changes
Apr 14, 2025
| npm run docs:deploy | ||
| npx standard-version | ||
| else | ||
| npm install |
Contributor
Author
There was a problem hiding this comment.
@Jeevan-Kishore
Yes, I did , am still working on it, will release new version tomorrow.
I am debugging an issue — specifically, when we release an AMP beta version, the new version isn’t getting updated under the packages key in package-lock.json. This causes the frontend to continue using the old AMP version, which leads to issues. So I was trying this change to see if it would help resolve the problem.
Thank you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include the summary of the change made. Please include the required context here. Please include the issue reference for the fix and the dependencies reference for the change.
Fixes # (issue-reference)
Dependencies # (dependency-issue-reference)
Documentation # (link to the corresponding documentation changes)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: