Conversation
ags1773
commented
Feb 12, 2023
Comment on lines
+39
to
+46
| // it("should pass localized formattedDate to <DateTime />", () => { | ||
| // const wrapper = mount( | ||
| // <ThemeProvider theme={defaultTokens}> | ||
| // <DateFirstPublishedBase story={getDummyStory()} config={config} /> | ||
| // </ThemeProvider> | ||
| // ); | ||
| // expect(wrapper.find(DateTime).prop("formattedDate")).toBe("February 12, 2020, 4:07 PM"); | ||
| // }); |
Contributor
Author
There was a problem hiding this comment.
Unrelated to this change, these tests are failing on master
Collaborator
There was a problem hiding this comment.
do we have a followup ticket for this? so that someone can fix it later
ags1773
commented
Feb 12, 2023
Comment on lines
+37
to
+44
| // it("should pass localized formattedDate to <DateTime />", () => { | ||
| // const wrapper = mount( | ||
| // <ThemeProvider theme={defaultTokens}> | ||
| // <DateLastPublishedBase story={getDummyStory()} config={config} /> | ||
| // </ThemeProvider> | ||
| // ); | ||
| // expect(wrapper.find(DateTime).prop("formattedDate")).toBe("May 27, 2020, 6:01 AM"); | ||
| // }); |
Jeevan-Kishore
previously approved these changes
Feb 13, 2023
Athira001
previously approved these changes
Feb 13, 2023
| case "theme-2": | ||
| const themeConfig2 = visualStoriesConfig[1] || {}; | ||
| return themeConfig2.ads?.doubleclick?.dataSlot; | ||
| return adConfigForTheme(themeConfig2); |
Contributor
There was a problem hiding this comment.
can we update the doc as well?
ReenaSingh07
requested changes
Feb 13, 2023
package.json
Outdated
| "dist" | ||
| ], | ||
| "scripts": { | ||
| "copy": "npm run build && rm /Users/amogh/work/malibu/node_modules/@quintype/amp/dist/index.js && cp /Users/amogh/work/quintype-amp/dist/index.js /Users/amogh/work/malibu/node_modules/@quintype/amp/dist", |
Comment on lines
+39
to
+46
| // it("should pass localized formattedDate to <DateTime />", () => { | ||
| // const wrapper = mount( | ||
| // <ThemeProvider theme={defaultTokens}> | ||
| // <DateFirstPublishedBase story={getDummyStory()} config={config} /> | ||
| // </ThemeProvider> | ||
| // ); | ||
| // expect(wrapper.find(DateTime).prop("formattedDate")).toBe("February 12, 2020, 4:07 PM"); | ||
| // }); |
Collaborator
There was a problem hiding this comment.
do we have a followup ticket for this? so that someone can fix it later
| const adSlot = get(config, ["opts", "featureConfig", "visualStories", "ads", "doubleclick", "dataSlot"], null); | ||
| return typeof adSlot === "function" ? adSlot(config) : adSlot; | ||
| const adsConfig = { doubleClick: null, adsense: { clientId: null, slotId: null } }; | ||
| const doubleclickAdSlot = get( |
Collaborator
There was a problem hiding this comment.
can we destructure till ads as its used in multiple places
Contributor
Author
There was a problem hiding this comment.
going with this for now
ReenaSingh07
dismissed stale reviews from Athira001 and Jeevan-Kishore
via
609fbdf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/quintype/page-builder/issues/2226