Skip to content

legacy-issue-fix #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nandap4790 wants to merge 2 commits into
base: master
Choose a base branch
from
+22,475 −23,511
Open

legacy-issue-fix #596

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8972a75
legacy-issue-fix
nandap4790 Aug 21, 2025
8149f23
legacy-issue-fix
nandap4790 Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/publisher.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
asset_host: http://localhost:8080
asset_host: http://localhost:8081
Copy link

@coderabbitai coderabbitai bot Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Port switch to 8081 looks right—please verify no stale 8080 references remain and that cross-device dev works.

This aligns with the new webpack devServer port. To avoid surprises:

  • Search for any lingering localhost:8080 references.
  • If you test from a phone/another machine, localhost won’t resolve; consider using your LAN IP or an env-driven host for dev.

Run:

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# 1) Find stale :8080 references (excluding node_modules)
rg -nP 'localhost:8080|:8080\b' -g '!**/node_modules/**' -C2

# 2) Confirm the active asset_host points to 8081
rg -nP '^asset_host:\s*http://localhost:8081' -n config

# 3) Surface any other asset host config
rg -nP '\basset_host\b|\bASSET_HOST\b' -n

Length of output: 873

Synchronize asset server port references to 8081

We’ve confirmed the asset_host in config/publisher.yml is correctly set to http://localhost:8081, but there are still stale uses of port 8080 elsewhere. Please update the following so your local and cross-device workflows continue to work:

  • docker-compose.yml (lines 13–17)
    Currently mapping ["8080:8080"]. Change this to ["8081:8081"] (or your chosen host:container ports) so the asset server matching webpack’s devServer.port is exposed.
  • dev-docker/port-forward (line 3)
    Update the SSH tunnel from -L 8080:localhost:8080 to -L 8081:localhost:8081 (and any other forwarded ports) to mirror the new asset-server port.
  • run-prodish script (line 4)
    It runs sed -i "" 's/asset_host:.*$/asset_host:/' config/publisher.yml. Ensure any automation around resetting or templating the asset_host still works as intended now that the URL includes :8081.
  • README.md (line 22)
    Revise instructions around config/publisher.yml (e.g. “remove the asset_host”) to reflect that the default dev port is now 8081, and note any manual edits needed.
  • Cross-device access
    Remember that localhost won’t resolve on other devices. We recommend enabling an env-driven host (e.g. ASSET_HOST=http://192.168.x.y:8081) or documenting the LAN IP in your README for phone/tablet testing.

Once these updates are in place, rerun the grep checks to confirm no :8080 references remain and verify you can access the asset server both locally and from another machine.

🤖 Prompt for AI Agents 
In config/publisher.yml line 1 the asset_host is set to http://localhost:8081
but there are stale 8080 references elsewhere; update docker-compose.yml (lines
13–17) to map ["8081:8081"] instead of ["8080:8080"], change
dev-docker/port-forward line 3 to forward -L 8081:localhost:8081 (and any other
forwarded 8080 ports), adjust run-prodish script line 4 so its sed pattern still
correctly matches and preserves the full URL including :8081 (or update the sed
expression to handle :PORT), and revise README.md line 22 to document the new
default dev port 8081 and recommend using an env-driven host or LAN IP for
cross-device testing; after changes run a grep for ":8080" to ensure no
remaining references and verify local and remote access to the asset server.

sketches_host: https://malibu-advanced-web.qtstage.io
host_to_api_host:
help.lvh.me: https://user-documentation.quintype.io
Expand Down
Loading