Skip to content

Conversation

@marten-seemann
Copy link
Member

No description provided.

@marten-seemann marten-seemann requested a review from Copilot June 30, 2025 10:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a dedicated cleanup step for Docker containers and improves log directory handling before running integration tests.

  • Introduce clean-containers target and hook it into each test target
  • Add argument validation and directory reset in copylogs target
Comments suppressed due to low confidence (1)

integration/Makefile:58

  • [nitpick] Consider renaming the variable target to uppercase (e.g., TARGET) or a more descriptive name like LOG_DIR to avoid confusion with file targets and improve clarity.
	if [ -z "$(target)" ]; then echo "target directory not specified"; exit 1; fi

rm proxy/key.pem proxy/cert.pem || true

ping:
clean-containers:
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add clean-containers to the .PHONY declaration so Make treats it as a phony target and avoids conflicts with files of the same name.

Copilot uses AI. Check for mistakes.
@codecov
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.38%. Comparing base (3d8a18f) to head (afb1b2b).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   87.96%   88.38%   +0.41%     
==========================================
  Files           8        8              
  Lines         673      680       +7     
==========================================
+ Hits          592      601       +9     
+ Misses         62       60       -2     
  Partials       19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Copilot <[email protected]>
@marten-seemann marten-seemann merged commit fbc85eb into master Jun 30, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants