Skip to content

Fix handling of empty todo query parameter #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Fix handling of empty todo query parameter #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion tests/src/test/java/com/sun/ts/tests/jaxrs/ee/rs/cookieparam/CookieParamTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,15 @@ public Response cookieParamHandling(@QueryParam("todo") String todo,
Response.ResponseBuilder respb = Response.status(200);

if (todo == null) {
sb.append("other stuff");
setReturnValues(paramEntityWithConstructor, paramEntityWithFromString,
paramEntityWithValueOf, setParamEntityWithFromString,
sortedSetParamEntityWithFromString, listParamEntityWithFromString,
"");
setReturnValues(fieldParamEntityWithConstructor,
fieldParamEntityWithFromString, fieldParamEntityWithValueOf,
fieldSetParamEntityWithFromString,
fieldSortedSetParamEntityWithFromString,
fieldListParamEntityWithFromString, FIELD);
} else if (todo.equalsIgnoreCase("setCookie")) {
String cookie_name = "name1";
String cookie_value = "value1";
Expand All @@ -98,6 +106,7 @@ public Response cookieParamHandling(@QueryParam("todo") String todo,
sb.append("name1" + "=" + value);
sb.append("verifyCookie=done");
} else if (todo.equals("")) {
// TODO this block can be removed after https://github.com/quarkusio/quarkus/pull/42468 is merged, kept only for backwards compat
setReturnValues(paramEntityWithConstructor, paramEntityWithFromString,
paramEntityWithValueOf, setParamEntityWithFromString,
sortedSetParamEntityWithFromString, listParamEntityWithFromString,
Expand Down