Skip to content

Fix: Persist ChatMemory when Tool ReturnBehavior is IMMEDIATE (#2017) #2025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codesmith25103 wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −0
Open

Fix: Persist ChatMemory when Tool ReturnBehavior is IMMEDIATE (#2017) #2025

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...va/io/quarkiverse/langchain4j/runtime/aiservice/AiServiceMethodImplementationSupport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,6 +468,7 @@ private static Object doImplement0(AiServiceMethodCreateInfo methodCreateInfo, I
committableChatMemory.add(toolResult);
}
if (immediateToolReturn) {
committableChatMemory.commit();
Copy link

@stanlayze stanlayze Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we commit the messages after the type-check in the next 3 lines?

Copy link
Collaborator

@geoand geoand Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that probably makes sense

if (!TypeUtil.isResult(returnType)) {
throw IllegalConfigurationException
.illegalConfiguration("@Tool with IMMEDIATE return behavior must return a Result");
Expand Down