Skip to content

Update the default chat model id for Gemini to gemini-2.5-flash #1822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
geoand merged 1 commit into from
Sep 26, 2025
Merged

Update the default chat model id for Gemini to gemini-2.5-flash #1822

geoand merged 1 commit into from
Sep 26, 2025

Conversation

@fjuma
Copy link
Contributor

@fjuma fjuma commented Sep 26, 2025

This PR updates the default chat model id for the Gemini chat model to gemini-2.5-flash since gemini-1.5-flash has been discontinued from Sept. 24th.

Fixes #1819

@fjuma fjuma requested a review from a team as a code owner September 26, 2025 15:21
geoand
geoand approved these changes Sep 26, 2025
View reviewed changes
Copy link
Collaborator

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@quarkus-bot

This comment has been minimized.

Sign in to view
@fjuma
Copy link
Contributor Author

fjuma commented Sep 26, 2025

@geoand It seems just org.acme.example.gemini.aiservices.AssistantResourceWithToolsTest is failing with the following error:

2025-09-26 15:33:09,166 INFO  [io.qua.lan.ver.run.gem.VertxAiGeminiRestApi$VertxAiClientLogger] (vert.x-eventloop-thread-1) Request:
- method: POST
- url: http://localhost:8081/gemini/v1/projects/my_google_project_id/locations/west-europe/publishers/google/models/gemini-2.5-flash:generateContent
- headers: [Authorization: *** [Content-Type: application/json], [User-Agent: Quarkus REST Client], [content-length: 357]
- body: {"contents":[{"role":"user","parts":[{"text":"This is a test"}]}],"tools":[{"functionDeclarations":[{"name":"duplicateContent","description":"Duplicate content","parameters":{"type":"object","properties":{"content":{"type":"string"}},"required":["content"]}}]}],"generationConfig":{"maxOutputTokens":8192,"responseMimeType":"text/plain","stopSequences":[]}}
2025-09-26 15:33:09,177 INFO  [io.qua.lan.ver.run.gem.VertxAiGeminiRestApi$VertxAiClientLogger] (vert.x-eventloop-thread-1) Response:
- status code: 404
- headers: [content-type: text/html; charset=utf-8], [content-length: 53]
- body: <html><body><h1>Resource not found</h1></body></html>
2025-09-26 15:33:09,189 ERROR [io.qua.ver.htt.run.QuarkusErrorHandler] (executor-thread-1) HTTP Request to /assistant-with-tool?message=This%20is%20a%20test failed, error id: dcb2728e-d360-447c-83fc-986acfe762e4-1: org.jboss.resteasy.reactive.ClientWebApplicationException: Received: 'Not Found, status code 404' when invoking REST Client method: 'io.quarkiverse.langchain4j.vertexai.runtime.gemini.VertxAiGeminiRestApi#generateContent'

Is there anything special I need to do for this test to make http://localhost:8081/gemini/v1/projects/my_google_project_id/locations/west-europe/publishers/google/models/gemini-2.5-flash:generateContent work?

gemini-2.5-flash is a valid model for Vertex AI (https://cloud.google.com/vertex-ai/generative-ai/docs/models/gemini/2-5-flash).

@geoand
Copy link
Collaborator

geoand commented Sep 26, 2025

The test doesn't actually hit the real service.

https://github.com/quarkiverse/quarkus-langchain4j/blob/ca25dc1fbe8154eb94f78c1322ba2ac13e1b13b2/integration-tests/ai-gemini/src/main/java/org/acme/example/gemini/aiservices/GeminiResource.java needs to be updated

@fjuma
Copy link
Contributor Author

fjuma commented Sep 26, 2025

Thanks for the pointer! It's strange, I have updated GeminiResource here:

https://github.com/quarkiverse/quarkus-langchain4j/pull/1822/files#diff-20f45f339267ce8fca4ea0100d4946d521cb5db0ee24688626b762c00744c2f9R19

@fjuma
Copy link
Contributor Author

fjuma commented Sep 26, 2025

@geoand Ah, I see now, there's another GeminiResource under vertex-ai-gemini that I need to update. Thanks!

@geoand
Copy link
Collaborator

geoand commented Sep 26, 2025

🙏

@geoand geoand merged commit f192aab into quarkiverse:main Sep 26, 2025
80 checks passed
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 26, 2025

Status for workflow Build (on pull request)

This is the status report for running Build (on pull request) on commit 5ffa8af.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geoand geoand geoand approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update the default chat model id for the Gemini chat model

2 participants

@fjuma @geoand