Add a {k0,tlb}lock test case #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
androm3da
force-pushed
the
bcain/lock_timer_test
branch
from
b3eb49f to
452c5ef
Compare
androm3da
force-pushed
the
bcain/lock_timer_test
branch
from
452c5ef to
1c3a9f2
Compare
| *qtmr_cntp_ctl = 1; | ||
| } | ||
|
|
||
| void add_translation(void *va, void *pa, int cacheability); |
There was a problem hiding this comment.
Isn't this defined in hexagon_standalone.h?
Comment on lines
326
to
327
| // Verify total interrupt counts are reasonable (greater than 10) | ||
| if (total_ints_by_tid <= 1) { |
Comment on lines
333
to
334
| if (total_ints_by_irq <= 1) { | ||
| printf("ERROR: Total interrupts by IRQ (%d) should be greater than 10\n", |
Comment on lines
+292
to
+290
| printf("SWI instructions issued: %d\n", swi_issued_count); | ||
| printf("Expected total interrupts: %d\n", total_expected_interrupts); |
| return 0; | ||
| } | ||
|
|
||
| static bool verify_no_overlaps(void) { |
| static bool verify_no_overlaps(void) { | ||
| int total_records = global_round_counter; | ||
|
|
||
| assert(total_records > 100); |
There was a problem hiding this comment.
Nitpick: this will aways be > N_THREADS * 400, no? Is this assertion necessary?
quic-mathbern
approved these changes
Nov 5, 2025
This new test case improves upon existing tests by making stricter assertions. The test runs concurrent HW threads trying to access the lock and each recording the time stamps from when it was held, then compares the threads' results to make sure there's no intersection. Signed-off-by: Brian Cain <[email protected]>
androm3da
force-pushed
the
bcain/lock_timer_test
branch
from
b1d0466 to
de7ace2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new test case improves upon existing tests by making stricter assertions. The test runs concurrent HW threads trying to access the lock and each recording the time stamps from when it was held, then compares the threads' results to make sure there's no intersection.