Clean headers #257
Open
Clean headers #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add GDSP-related libraries to lib_LTLIBRARIES, they were missed in the original commit. Fixes: 1ee463d ("Add changes to support GPDSPs offloading") Signed-off-by: Dmitry Baryshkov <[email protected]>
Stop declaring non-API functions in a fastrpc_notif.h Signed-off-by: Dmitry Baryshkov <[email protected]>
The dspqueue_sahred.h header is only used by dspqueue_cpu.c. Inline header contents into the corresponding file. Signed-off-by: Dmitry Baryshkov <[email protected]>
In order to prevent extra confusion (and in preparation to integtating QAIC into the build process in future) move all QAIC-generated files to a separate location. Signed-off-by: Dmitry Baryshkov <[email protected]>
Contributor
Author
|
Why is the code being built with the compiler from 2019? The |
Extract local API into a BSD-licensed copy of the upstream misc/fastrpc.h header. Signed-off-by: Dmitry Baryshkov <[email protected]>
Drop several headers (and source files) which are not longer user by anything. Signed-off-by: Dmitry Baryshkov <[email protected]>
Clean the API of fastrpc_ioctl.h header, dropping unused (or useless) defines. Signed-off-by: Dmitry Baryshkov <[email protected]>
ekanshibu
reviewed
Nov 24, 2025
| libsdsp_default_listener_la_LDFLAGS = libsdsprpc.la -shared -module $(USE_LOG) -version-number @LT_VERSION_NUMBER@ | ||
| libsdsp_default_listener_la_CFLAGS = $(SDSP_CFLAGS) -DUSE_SYSLOG | ||
|
|
||
| GDSP_CFLAGS = $(LIBDSPRPC_CFLAGS) -DDEFAULT_DOMAIN_ID=5 |
Contributor
There was a problem hiding this comment.
libgdsprpc was actually intended to not be added as we are sticking with multidomain-only approach for gdsp. Here domain is always passed explicitly and no need to rely on library to extract domain information. So we can basically reuse any existing library and just pass the domain name to make it work. (example: ./gdsprpcd rootpd gdsp0)
I think it would be better to remove libgdsprpc_la* and libgdsp_default_listener* completely and just build gdsprpcd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion in #253 , reorg headers and source files a bit.