Add workflow to trigger a build of the package repo #251
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
|
|
||
| name: Package Build PR Check | ||
| description: | | ||
| This workflow will execute when a PR is open against the configured branch. | ||
| On top of whatever kind of CI/CD logic happens in this upstream repo, this | ||
| workflow will make sure that what is attempted to be merged in the main release | ||
| branch won't break the debian package. The variable PKG_REPO_GITHUB_NAME needs to | ||
| be set in the repo where this file reside. This variable hold the packaging repo | ||
| name on github associated to this upstream repo. What will happen is that the PR | ||
| triggering this workflow will go knock on the packaging repo's door and trigger | ||
| a full build of the package if it were to include these changes. | ||
|
|
||
| on: | ||
| pull_request_target: | ||
| branches: [ main, development ] | ||
|
|
||
| permissions: | ||
| contents: read | ||
| security-events: write | ||
|
Contributor
There was a problem hiding this comment. why security-events need to have write permissions? Is there any code scanning happening with this workflow? |
||
|
|
||
|
Contributor
There was a problem hiding this comment. Is concurrency check also needed here? Say if multiple PR updates happen quickly? |
||
| jobs: | ||
| package-build-pr-check: | ||
|
Contributor
There was a problem hiding this comment. adding |
||
| uses: qualcomm-linux/qcom-build-utils/.github/workflows/qcom-upstream-pr-pkg-build-reusable-workflow.yml@main | ||
| with: | ||
| qcom-build-utils-ref: main | ||
| upstream-repo: ${{github.repository}} | ||
| upstream-repo-ref: ${{github.head_ref}} | ||
| pkg-repo: ${{vars.PKG_REPO_GITHUB_NAME}} | ||
| pr-number: ${{github.event.pull_request.number}} | ||
| secrets: | ||
| TOKEN: ${{ secrets.DEB_PKG_BOT_CI_TOKEN }} | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be
pull_requestinstead ofpull_request_target? Or is it intended to run the workflow against the base repo instead of the PR's repo? I'm assuming this workflow is intended for all the PRs that are getting raised for this project.