Skip to content

Conversation

@henryju
Copy link

@henryju henryju commented Nov 29, 2024

No description provided.

@ceki ceki merged commit 1a5c37e into qos-ch:branch_2.1.x Dec 12, 2024
1 check failed
@ceki
Copy link
Member

ceki commented Dec 12, 2024

@henryju Thank you for catching this. Please keep in mind that PRs need to be signed-off, i.e. the -s flag must be set when issuing the "git commit" command.

@henryju
Copy link
Author

henryju commented Dec 12, 2024

I submitted the change using GitHub online editor directly, not sure how I can sign in this case.

@henryju henryju deleted the patch-1 branch December 12, 2024 13:47
@ceki
Copy link
Member

ceki commented Dec 12, 2024

@henryju I see. I had not considered the online editor. Thank you for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants