[CORRUPTED] Synthetic Benchmark PR #64629 - Accept blazor.web.js startup options format in blazor.server.js and blazor.webassembly.js #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark PR dotnet#64629
Type: Corrupted (contains bugs)
Original PR Title: Accept blazor.web.js startup options format in blazor.server.js and blazor.webassembly.js
Original PR Description: - [x] Analyze issue requirements and understand the codebase
Boot.Server.tsto accept thecircuit:nested option formatBoot.WebAssembly.tsto accept thewebAssembly:nested option format///XML doc comments from test filesSecurity Summary
No security vulnerabilities were introduced by these changes.
Original prompt
This section details on the original issue you should resolve
<issue_title>[Blazor] Accept the
blazor.web.jsstartup options format inblazor.{server|webassembly}.js</issue_title><issue_description>## Problem
When a Blazor app uses
blazor.web.js, the options object passed toBlazor.start()has the following format:However, when using
blazor.server.jsorblazor.webassembly.js, runtime-specific options are specified as top-level properties on the options object. So, for example, if you're usingblazor.webassembly.jsand you attempt to customize the loading of boot resources like this:...then it will just silently "not work". This could create a pit of failure for customers who see examples in docs using the
blazor.web.jsoptions format but are writing a Blazor WebAssembly standalone app, for example.Solution
We should update
blazor.webassembly.jsandblazor.server.jsto accept the options format used byblazor.web.js.Include end-to-end test that will assert that options are passed correctly
Summary Comment: dotnet#51611 (comment)
</issue_description>
<agent_instructions>Follow the instructions in src/Components/Agents.md
You MUST follow this workflow when implementing new features or fixing bugs in the Components area.
todosand follow it strictly.In this case, for the E2E tests you can probably modify one of the
App.razorfiles in the testassets that use blazor.web.js and take parameters to use the new format. Make sure that there is at least one file that uses the new format and one that uses the old format.</agent_instructions>Comments on the Issue (you are @copilot in this section)
@ Thanks for contacting us.We're moving this issue to the
.NET 9 Planningmilestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.</comment_new>
<comment_new>@
Thanks for contacting us.
We're moving this issue to the
.NET 9 Planningmilestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.</comment_new>
<comment_new>@MackinnonBuck
Help Wanted
Issue Summary
See dotnet#51611 (comment)
Potential Design
We can add one additional property to
CircuitStartOptionsand `WebAssemblySt...blazor.web.jsstartup options format inblazor.{server|webassembly}.jsdotnet/aspnetcore#51611✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Original PR URL: dotnet#64629