[CORRUPTED] Synthetic Benchmark PR #41339 - feat: made changes to expose the App's height and width as part of the appsmith.ui state object#2
Open
tomerqodo wants to merge 9 commits intobase_pr_41339_20251124_6462from
Conversation
…tate object. And added reduces, actions and saga to update it dynamically whenever the browser height or width changes.
…ents to avoid heavy evaluations.
…ling the updateWindowDimensions on page load of editor and view mode. If any browser resize happens, user is expected refresh page.
…nly when its enabled will the appsmith state object have a ui object. Currently setting it as true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR appsmithorg#41339
Type: Corrupted (contains bugs)
Original PR Title: feat: made changes to expose the App's height and width as part of the appsmith.ui state object
Original PR Description: ## Description
Introducing this property as part of appsmith.ui state object, so that it can be used in cases like passing to a custom widget which can help in determining height of the widget with respective to the App's visible height
Example of usage below:
appsmith-ui-dimensions.mp4
Additional Info: Controlling this by a feature flag only at the selector level. Could not do it at the component level as one of the dispatch action occurs from a class based component that does not support hooks like useFeatureFlag
Tip
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).
Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.
Fixes #
Issue Numberor
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/19159166010
Commit: 134a977
Cypress dashboard.
Tags:
@tag.AllSpec:
Fri, 07 Nov 2025 06:39:25 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
Original PR URL: appsmithorg#41339
Issues Breakdown