Skip to content

[CORRUPTED] Synthetic Benchmark PR #41339 - feat: made changes to expose the App's height and width as part of the appsmith.ui state object#2

Open
tomerqodo wants to merge 9 commits intobase_pr_41339_20251124_6462from
corrupted_pr_41339_20251124_6462
Open

[CORRUPTED] Synthetic Benchmark PR #41339 - feat: made changes to expose the App's height and width as part of the appsmith.ui state object#2
tomerqodo wants to merge 9 commits intobase_pr_41339_20251124_6462from
corrupted_pr_41339_20251124_6462

Conversation

@tomerqodo
Copy link

Benchmark PR appsmithorg#41339

Type: Corrupted (contains bugs)

Original PR Title: feat: made changes to expose the App's height and width as part of the appsmith.ui state object
Original PR Description: ## Description
Introducing this property as part of appsmith.ui state object, so that it can be used in cases like passing to a custom widget which can help in determining height of the widget with respective to the App's visible height
Example of usage below:

appsmith-ui-dimensions.mp4

Additional Info: Controlling this by a feature flag only at the selector level. Could not do it at the component level as one of the dispatch action occurs from a class based component that does not support hooks like useFeatureFlag

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/19159166010
Commit: 134a977
Cypress dashboard.
Tags: @tag.All
Spec:


Fri, 07 Nov 2025 06:39:25 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • New Features
    • Added viewport dimension tracking (height & width) across the app.
    • Window dimensions are available in app state and exposed in the data tree for use in responsive logic and bindings.
    • Initial dimensions are captured on app load so widgets and pages can react to current viewport size (feature guarded by a rollout flag).

Original PR URL: appsmithorg#41339

Issues Breakdown

  • Total Issues: 7
  • Easy: 3
  • Medium: 2
  • Hard: 2

tomjose92 and others added 9 commits October 29, 2025 13:53
…tate object. And added reduces, actions and saga to update it dynamically whenever the browser height or width changes.
…ling the updateWindowDimensions on page load of editor and view mode. If any browser resize happens, user is expected refresh page.
…nly when its enabled will the appsmith state object have a ui object. Currently setting it as true.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants