Skip to content

Conversation

@Anthony-Gandon
Copy link
Contributor

@Anthony-Gandon Anthony-Gandon commented May 31, 2023

Summary

Fix #795

This draft PR introduces a MixedOp for manipulating systems corresponding to various "local" Hilbert spaces.
An implementation of the MixedMapper for mapping this operator into a sum of qubit operators acting on the composed registers is also proposed.

Updated tutorial
MixedOpTutorial.zip

@CLAassistant
Copy link

CLAassistant commented Jun 7, 2023

CLA assistant check
All committers have signed the CLA.

@Anthony-Gandon
Copy link
Contributor Author

Anthony-Gandon commented Nov 15, 2023

Update on the status of this PR.

  • The MixedOp was implemented and will probably not change much
  • The MixedMapper was implemented for the typical application to 1 system of Fermions coupled with 1 system of bosons. I still have in mind a generalization to allow for multiple fermionic subsystems.
    See images for the two ways to think of the problem. The first way assumes that we don't need to antisymmetrize the two subsystems
    equation(2)

@coveralls
Copy link

coveralls commented Jan 29, 2025

Pull Request Test Coverage Report for Build 14032193908

Details

  • 88 of 100 (88.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 85.995%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_nature/second_q/mappers/mixed_mapper.py 43 44 97.73%
qiskit_nature/second_q/operators/mixed_op.py 43 54 79.63%
Totals Coverage Status
Change from base Build 13920710812: 0.04%
Covered Lines: 8873
Relevant Lines: 10318

💛 - Coveralls

Copy link
Collaborator

@ftroisi ftroisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, thanks!
I mostly commented on the docstrings

@ftroisi ftroisi added the type: feature request New feature or request label Mar 6, 2025
@ftroisi ftroisi marked this pull request as ready for review March 14, 2025 14:23
Copy link
Collaborator

@fpietra fpietra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of very small comments.
Once they're addressed either positively or negatively, it looks good to merge.

@ftroisi ftroisi self-requested a review March 24, 2025 10:37
Copy link
Collaborator

@ftroisi ftroisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Anthony-Gandon for this valuable contribution!

@fpietra fpietra merged commit 3ec7d79 into qiskit-community:main Mar 24, 2025
37 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: feature request New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement a MixedOperator

6 participants