-
Notifications
You must be signed in to change notification settings - Fork 226
First proposal for the MixedMapper and MixedOp #1188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 14032193908Details
💛 - Coveralls |
8104c6e to
bec790e
Compare
ftroisi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, thanks!
I mostly commented on the docstrings
releasenotes/notes/introduce-mixedop-and-mixed-mapper-46f0ef30314c71c0.yaml
Outdated
Show resolved
Hide resolved
fpietra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple of very small comments.
Once they're addressed either positively or negatively, it looks good to merge.
Co-authored-by: Francesca Pietracaprina <[email protected]>
ftroisi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Anthony-Gandon for this valuable contribution!

Summary
Fix #795
This draft PR introduces a MixedOp for manipulating systems corresponding to various "local" Hilbert spaces.
An implementation of the MixedMapper for mapping this operator into a sum of qubit operators acting on the composed registers is also proposed.
Updated tutorial
MixedOpTutorial.zip