Add particular port for registered service when goc build #54
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: memoryliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 51.01% 51.04% +0.02%
==========================================
Files 31 32 +1
Lines 1578 1585 +7
==========================================
+ Hits 805 809 +4
- Misses 654 657 +3
Partials 119 119
Continue to review full report at Codecov.
|
pkg/cover/instrument.go
Outdated
| agentPort := "{{.AgentPort }}" | ||
| if agentPort != "" { | ||
| ln, err = net.Listen("tcp4", agentPort) | ||
| }else { |
cmd/commonflags.go
Outdated
| func addCommonFlags(cmdset *pflag.FlagSet) { | ||
| addBasicFlags(cmdset) | ||
| cmdset.StringVar(&mode, "mode", "count", "coverage mode: set, count, atomic") | ||
| cmdset.StringVar(&agentPort, "agentport", "", "specify fixed port for registered service") |
There was a problem hiding this comment.
suggest to enhance usage, like:
the port to listen when the registered service starting, if not provided, it will listen a random one
There was a problem hiding this comment.
update:
specify fixed port for registered service communicate with goc server. if not provided, using a random port
|
/lgtm |
3 participants
#52