Skip to content

Conversation

@xen0n
Copy link
Collaborator

@xen0n xen0n commented Apr 14, 2022

No description provided.

- Build with go1.18.x
- Test against 3 latest go versions
@xen0n xen0n force-pushed the generics branch 2 times, most recently from c3be080 to 417fa41 Compare April 15, 2022 07:00
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #277 (2b93476) into master (32647ea) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
- Coverage   71.05%   70.95%   -0.10%     
==========================================
  Files          34       34              
  Lines        2011     2011              
==========================================
- Hits         1429     1427       -2     
- Misses        472      474       +2     
  Partials      110      110              
Flag Coverage Δ
e2e-1.11.x ?
e2e-1.12.x ?
e2e-1.13.x ?
e2e-1.14.x ?
e2e-1.15.x ?
e2e-1.16.x ?
unittest-1.13.x ?
unittest-1.14.x ?
unittest-1.15.x ?
unittest-1.16.x 70.95% <ø> (ø)
unittest-1.17.x 70.86% <ø> (?)
unittest-1.18.x 70.86% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/build/gomodules.go 89.18% <0.00%> (-5.41%) ⬇️

@xen0n xen0n marked this pull request as ready for review April 15, 2022 07:14
@qiniu-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lyyyuna, xen0n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lyyyuna lyyyuna merged commit 3723142 into qiniu:master Apr 15, 2022
@xen0n xen0n deleted the generics branch April 15, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants