Skip to content

Conversation

@CarlJi
Copy link
Collaborator

@CarlJi CarlJi commented Nov 22, 2021

fix #247

@qiniu-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CarlJi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #248 (f45f938) into master (4b501e1) will decrease coverage by 0.14%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
- Coverage   71.10%   70.95%   -0.15%     
==========================================
  Files          34       34              
  Lines        2011     2011              
==========================================
- Hits         1430     1427       -3     
- Misses        473      474       +1     
- Partials      108      110       +2     
Flag Coverage Δ
e2e-1.11.x ?
e2e-1.12.x ?
e2e-1.13.x ?
e2e-1.14.x ?
e2e-1.15.x ?
e2e-1.16.x ?
unittest-1.13.x 70.86% <50.00%> (-0.25%) ⬇️
unittest-1.14.x 70.95% <50.00%> (-0.15%) ⬇️
unittest-1.15.x 70.86% <50.00%> (-0.25%) ⬇️
unittest-1.16.x 70.86% <50.00%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/build/tmpfolder.go 66.03% <50.00%> (-4.72%) ⬇️
pkg/build/legacy.go 100.00% <0.00%> (+4.87%) ⬆️

@CarlJi
Copy link
Collaborator Author

CarlJi commented Nov 22, 2021

/assign @lyyyuna

@lyyyuna lyyyuna merged commit 1537615 into qiniu:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

goc形式运行gopath项目报错,辛苦帮忙看下,谢谢!

3 participants