feat: 使用mod=vendor时候不应该更新go.mod文件 #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/assign @memoryliu |
fix code style
change err name
Collaborator
|
/assign @lyyyuna |
Collaborator
|
Thanks for your PR @socket515 /lgtm |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CarlJi, socket515 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
==========================================
+ Coverage 68.48% 71.17% +2.69%
==========================================
Files 34 34
Lines 1745 2009 +264
==========================================
+ Hits 1195 1430 +235
- Misses 445 471 +26
- Partials 105 108 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
使用
go build -mod=vendor编译的时候，不应该去更新go.mod文件, 因为相关依赖都在vendor文件里了，如果更新了go.mod文件会导致vendor目录和go.mod文件内容不一致