Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## removecupy #249 +/- ##
============================================
Coverage 100.00% 100.00%
============================================
Files 7 7
Lines 669 669
============================================
Hits 669 669
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
scarrazza
commented
Mar 11, 2026
| # this might be jittable if we passed the shape | ||
| # dim = (2,) * 2 * nqubits as inputs | ||
| @njit | ||
| @njit(cache=True) |
Member
Author
There was a problem hiding this comment.
@BrunoLiegiBastonLiegi any motivation do avoid caching this in your original implementation?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #246 by removing import-AOT compilation. Tests are faster and dry run of a QFT improves from 2' (main) to 5''.