SNZ calibration protocols#1151
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1151 +/- ##
==========================================
+ Coverage 97.72% 97.84% +0.11%
==========================================
Files 128 131 +3
Lines 9644 10042 +398
==========================================
+ Hits 9425 9826 +401
+ Misses 219 216 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
andrea-pasquale
left a comment
There was a problem hiding this comment.
Thanks @Edoardo-Pedicillo, most of the comments are mostly related to documentation (missing docstrings or leftover print statements).
To better understand what is going on in each protocol it would be nice to have a dedicated page in the documentation (which we could do in another PR if you just want to have this as it is in main).
Before merging it would be nice to enable tests with dummy to make sure that we don't have any silly errors.
Co-authored-by: Andrea Pasquale <andreapasquale97@gmail.com>
andrea-pasquale
left a comment
There was a problem hiding this comment.
Thanks @Edoardo-Pedicillo, everything looks good.
I have just a comment removing some print statements.
On another note, we are missing documentation. It would be nice to have a dedicated page where we explain how to run all these SNZ related protocols. Feel free to open an issue and do it in another PR.
Co-authored-by: Andrea Pasquale <andreapasquale97@gmail.com>
Co-authored-by: Andrea Pasquale <andreapasquale97@gmail.com>
This PR is implementing some protocols for the calibration of the SNZ pulse.