Skip to content

SNZ calibration protocols#1151

Merged
Edoardo-Pedicillo merged 26 commits into
mainfrom
snz_tuning
Jul 25, 2025
Merged

SNZ calibration protocols#1151
Edoardo-Pedicillo merged 26 commits into
mainfrom
snz_tuning

Conversation

@Edoardo-Pedicillo

@Edoardo-Pedicillo Edoardo-Pedicillo commented May 16, 2025

Copy link
Copy Markdown
Contributor

This PR is implementing some protocols for the calibration of the SNZ pulse.

@Edoardo-Pedicillo Edoardo-Pedicillo marked this pull request as draft May 16, 2025 14:27
Base automatically changed from vz_devug to main May 19, 2025 06:11
@andrea-pasquale andrea-pasquale linked an issue May 26, 2025 that may be closed by this pull request
@codecov

codecov Bot commented Jun 11, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 99.31973% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.84%. Comparing base (fd11b17) to head (98cfc45).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
...c/qibocal/protocols/two_qubit_interaction/utils.py 93.75% 2 Missing ⚠️
...al/protocols/two_qubit_interaction/snz_optimize.py 99.34% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1151      +/-   ##
==========================================
+ Coverage   97.72%   97.84%   +0.11%     
==========================================
  Files         128      131       +3     
  Lines        9644    10042     +398     
==========================================
+ Hits         9425     9826     +401     
+ Misses        219      216       -3     
Flag Coverage Δ
unittests 97.84% <99.31%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ibocal/protocols/two_qubit_interaction/__init__.py 100.00% <100.00%> (ø)
...ibocal/protocols/two_qubit_interaction/optimize.py 97.60% <100.00%> (ø)
...ocols/two_qubit_interaction/snz_optimize_t_idle.py 100.00% <100.00%> (ø)
..._qubit_interaction/snz_optimize_t_idle_vs_t_tot.py 100.00% <100.00%> (ø)
...rotocols/two_qubit_interaction/virtual_z_phases.py 100.00% <100.00%> (+2.43%) ⬆️
...al/protocols/two_qubit_interaction/snz_optimize.py 99.34% <99.34%> (ø)
...c/qibocal/protocols/two_qubit_interaction/utils.py 96.29% <93.75%> (-3.71%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Edoardo-Pedicillo Edoardo-Pedicillo marked this pull request as ready for review June 11, 2025 11:25

@andrea-pasquale andrea-pasquale left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Edoardo-Pedicillo, most of the comments are mostly related to documentation (missing docstrings or leftover print statements).
To better understand what is going on in each protocol it would be nice to have a dedicated page in the documentation (which we could do in another PR if you just want to have this as it is in main).
Before merging it would be nice to enable tests with dummy to make sure that we don't have any silly errors.

Comment thread src/qibocal/auto/task.py Outdated
Comment thread src/qibocal/protocols/two_qubit_interaction/snz_optimize.py Outdated
Comment thread src/qibocal/protocols/two_qubit_interaction/snz_optimize.py
Comment thread src/qibocal/protocols/two_qubit_interaction/snz_optimize.py Outdated
Comment thread src/qibocal/protocols/two_qubit_interaction/snz_optimize.py Outdated
Comment thread src/qibocal/protocols/two_qubit_interaction/snz_optimize_t_idle_vs_t_tot.py Outdated
Comment thread src/qibocal/protocols/two_qubit_interaction/snz_optimize_t_idle_vs_t_tot.py Outdated
Comment thread src/qibocal/protocols/two_qubit_interaction/snz_optimize_t_idle_vs_t_tot.py Outdated
Comment thread src/qibocal/protocols/two_qubit_interaction/snz_optimize_t_idle_vs_t_tot.py Outdated
Comment thread src/qibocal/protocols/two_qubit_interaction/snz_optimize_t_idle_vs_t_tot.py Outdated
@Edoardo-Pedicillo Edoardo-Pedicillo added this to the Qibocal 0.2.3 milestone Jun 19, 2025
@Edoardo-Pedicillo Edoardo-Pedicillo modified the milestones: Qibocal 0.2.3, Qibocal 0.2.4 Jul 21, 2025
@Edoardo-Pedicillo

Copy link
Copy Markdown
Contributor Author

@andrea-pasquale andrea-pasquale left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Edoardo-Pedicillo, everything looks good.
I have just a comment removing some print statements.
On another note, we are missing documentation. It would be nice to have a dedicated page where we explain how to run all these SNZ related protocols. Feel free to open an issue and do it in another PR.

Comment thread src/qibocal/protocols/two_qubit_interaction/utils.py Outdated
Comment thread src/qibocal/protocols/two_qubit_interaction/utils.py Outdated
Edoardo-Pedicillo and others added 2 commits July 25, 2025 14:28
Co-authored-by: Andrea Pasquale <andreapasquale97@gmail.com>
Co-authored-by: Andrea Pasquale <andreapasquale97@gmail.com>
@Edoardo-Pedicillo Edoardo-Pedicillo added this pull request to the merge queue Jul 25, 2025
Merged via the queue into main with commit 6de1e1d Jul 25, 2025
39 checks passed
@Edoardo-Pedicillo Edoardo-Pedicillo deleted the snz_tuning branch July 25, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2q gates - SNZ pulse optimisation

3 participants