Skip to content

[unitaryHack 2025] Support component-wise decompositions#1651

Closed
y-richie-y wants to merge 3 commits intoqiboteam:masterfrom
y-richie-y:decompose
Closed

[unitaryHack 2025] Support component-wise decompositions#1651
y-richie-y wants to merge 3 commits intoqiboteam:masterfrom
y-richie-y:decompose

Conversation

@y-richie-y
Copy link

Closes #1585

I implemented the "ideal" solution by leaving conjugation gates (when it is repeated on both sides) uncontrolled.

@renatomello renatomello added the unitaryHACK 2025 Issues related to the unitaryHACK 2025 label May 28, 2025
@renatomello renatomello changed the title Support component-wise decompositions [unitaryHack 2025] Support component-wise decompositions May 28, 2025
@y-richie-y
Copy link
Author

@renatomello anything I need to do to get this merged?

@y-richie-y
Copy link
Author

Any updates @renatomello? I see that since I have opened this PR there is now #1653 which is very similar to this one.

@scarrazza scarrazza added the run-workflow Forces github workflow execution label May 30, 2025
@y-richie-y
Copy link
Author

@renatomello do you plan on reviewing this PR?

@renatomello
Copy link
Contributor

renatomello commented Jun 6, 2025

@renatomello do you plan on reviewing this PR?

I'm sorry for the delay. We have three PRs open on the same issue and need to decide the "winner". I'm sorry I have been neglecting this PR but I'll be coming around to it soon.

One thing that I can say right now is that even though this solution works for the gates that were mentioned in the PR, it is not being applied to all the other native gates in the module.

@renatomello
Copy link
Contributor

@y-richie-y Thanks for opening this PR. Even though your solution works, we decided to move forward with the solution implemented in #1653 due to it being a bit more complete. We thank you for your input though.

@renatomello renatomello closed this Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-workflow Forces github workflow execution unitaryHACK 2025 Issues related to the unitaryHACK 2025

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug when using Gate.decompose on controlled gates

3 participants