feat: implement sorting and handling of StartTime in results #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
- Added functionality to sort results by StartTime when a RunID is provided, ensuring proper order during uploads. - Implemented logic to set StartTime and EndTime to nil after processing, enhancing data integrity. - Introduced unit tests to validate sorting behavior, handling of nil StartTime values, and truncation of long test titles to 255 characters. - Updated the Upload method to include title truncation and sorting logic, improving overall result management.
gibiw
force-pushed
the
improve/allure-upload
branch
from
83f0557 to
8f0611d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Sort results by StartTime for existing runs, clear time fields, and truncate titles to 255 runes with comprehensive tests.
internal/service/result/result.go):resultsbyExecution.StartTime(ascending; nils last) whenRunIDis provided, then clearsStartTime/EndTimeon each result before upload.StartTimevalues, nilStartTime, and long/UTF-8 titles infixture_test.go.result_test.gowith cases verifying sorting order, nil-time handling, time clearing, and safe UTF-8/rune-based title truncation.Written by Cursor Bugbot for commit 8f0611d. This will update automatically on new commits. Configure here.