Skip to content

Fix a bug that CMakeLists.txt could not be found when the package was installed.#5

Merged
pzelasko merged 1 commit intopzelasko:mainfrom
somniumism:fix/no_cmakelists
Sep 28, 2022
Merged

Fix a bug that CMakeLists.txt could not be found when the package was installed.#5
pzelasko merged 1 commit intopzelasko:mainfrom
somniumism:fix/no_cmakelists

Conversation

@somniumism
Copy link
Contributor

@somniumism somniumism commented Sep 28, 2022

Resolve #4

There is a bug that the package kaldialign-0.3 has not been installed since the PR #3 was reflected.

Adding CmakeLists.txt to MANIFEST.in seems to resolve this problem.

I have checked that the package is well built and installed in my local environment.

$ cd kaldialign
$ python setup.py bdist_wheel
...
$ pip install dist/kaldialign-0.4-cp39-cp39-macosx_12_0_x86_64.whl
...
Successfully installed kaldialign-0.4

Please double check if the package is well built and installed in your environment.

cc. @pzelasko @csukuangfj

@csukuangfj
Copy link
Contributor

Sorry, I only tested

python3 setup.py install

and

pip install --verbose -U git+https://github.com/pzelasko/kaldialign.git

I just tested with your changes

python3 setup.py sdist
cd dist
pip install ./*

and it works.

Thanks for the fix.

Copy link
Owner

@pzelasko pzelasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@pzelasko pzelasko merged commit 7831101 into pzelasko:main Sep 28, 2022
@somniumism somniumism deleted the fix/no_cmakelists branch September 28, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kaldialign-0.3 install failed

3 participants