Fix a bug that CMakeLists.txt could not be found when the package was installed.#5
Merged
pzelasko merged 1 commit intopzelasko:mainfrom Sep 28, 2022
Merged
Conversation
csukuangfj
reviewed
Sep 28, 2022
Contributor
|
Sorry, I only tested and I just tested with your changes and it works. Thanks for the fix. |
f7fa54b to
34359f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #4
There is a bug that the package
kaldialign-0.3has not been installed since the PR #3 was reflected.Adding
CmakeLists.txttoMANIFEST.inseems to resolve this problem.I have checked that the package is well built and installed in my local environment.
Please double check if the package is well built and installed in your environment.
cc. @pzelasko @csukuangfj