Descriptive param names, typing, update docs, add pre-commit hooks#18
Merged
Descriptive param names, typing, update docs, add pre-commit hooks#18
Conversation
boeddeker
reviewed
Mar 13, 2024
| return _kaldialign.edit_distance(ai, bi, sclite_mode) | ||
| ans = _kaldialign.edit_distance(refi, hypi, sclite_mode) | ||
| ans["ref_len"] = len(refi) | ||
| ans["err_rate"] = ans["total"] / len(refi) |
There was a problem hiding this comment.
FYI: This line introduces the bug, that edit_distance doesn't work for an empty reference, it raises a ZeroDivisionError.
Owner
Author
There was a problem hiding this comment.
right, I’ll fix that. We should probably return one of inf, nan, or None: WDYT?
There was a problem hiding this comment.
Thanks.
Hmm. How about mirroring the behavior of numpy?
>>> np.array([1]) / np.array([0])
array([inf])
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging this before the CI/wheel build fix and will release together as 0.8.1