Skip to content

Publish pre-built wheels#10

Merged
pzelasko merged 4 commits intopzelasko:mainfrom
csukuangfj:pre-built-wheels-2023-01-10
Jan 10, 2023
Merged

Publish pre-built wheels#10
pzelasko merged 4 commits intopzelasko:mainfrom
csukuangfj:pre-built-wheels-2023-01-10

Conversation

@csukuangfj
Copy link
Contributor

This PR publishes pre-built wheels to PyPI, like what we are doing for anaconda.

The advantage is that users don't need to install CMake or a C++ compiler any more. Also, it is faster to install.

@pzelasko

You need to do the following on your side.

  1. Visit https://github.com/pzelasko/kaldialign/settings/secrets/actions
  2. Click the green button: New repository secret.

Please add two secret.

Secret 1

  • Key: PYPI_USERNAME
  • Value: Your user name for PyPI

Secret 2

  • Key: PYPI_PASSWORD
  • Value: your password for PyPI

To release a new version, e.g., 0.6, please do the following

  1. Change
    set(KALDIALIGN_VERSION "0.5")

    to
 set(KALDIALIGN_VERSION "0.6") 
  1. Change

    to
 version: "0.6" 
git add CMakeLists.txt
git add scripts/conda/kaldialign/meta.yaml
git commit -m "Release v0.6"
git push 
git tag v0.6
git push origin v0.6

It will upload the pre-built wheels to anaconda and PyPI, magically.

@csukuangfj
Copy link
Contributor Author

I have tested the code on https://github.com/csukuangfj/kaldialign/actions/runs/3883951085

You can download the pre-built wheels and test them on your computer.

Screenshot 2023-01-10 at 22 05 46


Screenshot 2023-01-10 at 22 07 19

Copy link
Owner

@pzelasko pzelasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great work! I'm on it.

@pzelasko pzelasko merged commit d547ca4 into pzelasko:main Jan 10, 2023
@csukuangfj csukuangfj deleted the pre-built-wheels-2023-01-10 branch January 10, 2023 14:15
@csukuangfj
Copy link
Contributor Author

@pzelasko

I just tried to install kaldialign on my Linux server. It's really fast. No compiling is needed at all.

Will save other people's waiting time.

Screenshot 2023-01-10 at 22 27 53

@pzelasko
Copy link
Owner

Yeah and people won't have the issues related to cmake etc. anymore. Very cool!!

@csukuangfj
Copy link
Contributor Author

I have done the same thing for lilcom and other projects related to next-gen Kaldi that don't depend on PyTorch.

@csukuangfj
Copy link
Contributor Author

And for macOS
Screenshot 2023-01-10 at 22 35 26

@csukuangfj
Copy link
Contributor Author

Please follow
https://pypi.org/help/#apitoken
to update your github actions secret.

You need to change the username to __token__ and update the password to a newly-created API token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants