Bug: `pin.put_file_upload` does not work

[amks1]

Since the recent change that added the function pin.get_pin_values(), the pin.put_file_upload() function doesn't return a usable dict.

Test code:

import pywebio.pin as pin
import pywebio.output as pwo

def handle_convert():
    pinvalues = pin.get_pin_values(['files', 'mode'])
    file_upload1 = pinvalues['files']
    file_upload2 = pin.pin['files']
    print(file_upload1)
    print(file_upload2)

pin.put_file_upload('files', label='Upload files for conversion', multiple=False)
pwo.put_button('Convert', onclick=handle_convert)

In the above code, both file_upload1 and file_upload2 are dicts that look like this:

{'multiple': False, 'files': [{}]}

[wang0618]

Thankes for pointing that. I have fix the bug (available in dev version). I will do more tests to release next version (maybe in next week)

[amks1]

Thanks for the quick fix. I noticed one issue after the fix: Any time there are scope updates, the file gets reuploaded.

Test code:

import pywebio.pin as pin
import pywebio.output as pwo

SCOPE_TEXTAREA = 'scope_textarea'

def handle_convert():
    pinvalues = pin.get_pin_values(['files', 'mode'])
    file_upload1 = pinvalues['files']

def handle_radio_change(new_value):
        pwo.clear_scope(SCOPE_TEXTAREA)
        if new_value == 'to JSON':
            pin.put_textarea('mytext', label='Enter some text', rows=3, scope=SCOPE_TEXTAREA)

pin.put_file_upload('files', label='Upload files for conversion', multiple=False)
pin.put_radio('mode', 
        options=[
            'to XML',
            'to JSON',
        ]
    )
pin.pin_on_change('mode', handle_radio_change)
pwo.put_scope(SCOPE_TEXTAREA)
pwo.put_button('Convert', onclick=handle_convert)

In the above app, every time I change the radio option on the frontend, the file gets reuploaded.

[wang0618]

The file is upload twice because both pin.get_pin_values(['files', 'mode']) and pin.pin['files'] will cause uploading (pywebio will not cache the file data).

The pin.pin[name] syntax is somewhat misleading, as it makes people think that the data will be cached after being read. However, in fact, each time you use the pin.pin[name] to access the pin value, the value of the pin widget will be re-read from the frontend.

[amks1]

@wang0618 Sorry I copy pasted the wrong code by mistake. I've edited my comment now with the correct code.

The issue I described is not related to calling pin.pin[]. The file upload happens if I change the radio button option from the frontend.

If I change the radio button 10 times on the frontend, the file upload progress toast shows up 10 times.

Hope the bug is clear now.

[amks1]

@wang0618 I recorded a video to make the problem clearer:

Zight.Recording.2025-3-24.at.1.15.26.AM.mp4

[wang0618]

Fixed in latest dev version.

The bug is because I forgot that the bool value of an empty array in js is true 😂 (haven't written js for a while )

[amks1]

Fixed in latest dev version.

The bug is because I forgot that the bool value of an empty array in js is true 😂 (haven't written js for a while )

Confirmed, fixed now. Thanks for your effort 🤩