Move fci_l1c_fdhsi and viirs_l2_cloud_mask_nc to full deprecation#3298
Open
ameraner wants to merge 2 commits intopytroll:mainfrom
Open
Move fci_l1c_fdhsi and viirs_l2_cloud_mask_nc to full deprecation#3298ameraner wants to merge 2 commits intopytroll:mainfrom
ameraner wants to merge 2 commits intopytroll:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3298 +/- ##
==========================================
- Coverage 96.30% 96.29% -0.02%
==========================================
Files 463 463
Lines 58863 58863
==========================================
- Hits 56689 56683 -6
- Misses 2174 2180 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request Test Coverage Report for Build 19360172961Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves two readers that were pending deprecation since 4 years (FCI #1713) and 2 years (VIIRS, 65511ec, #2531) to full deprecation.
Now, instead of a warning, a ValueError will be raised, still pointing to the new reader name.