Skip to content

Require Numpy 2.0 or later#3294

Merged
pnuu merged 5 commits intopytroll:mainfrom
pnuu:drop-numpy-1.x-support
Nov 19, 2025
Merged

Require Numpy 2.0 or later#3294
pnuu merged 5 commits intopytroll:mainfrom
pnuu:drop-numpy-1.x-support

Conversation

@pnuu
Copy link
Member

@pnuu pnuu commented Nov 12, 2025

This PR drops Numpy 1.x support from Satpy.

There are were two functions in satpy.tests.utils that do did checks for Skyfield and h5py and their Numpy 2 support which might need checking were removed. The removal of Skyfield also revealed a bug in satpy.utils._get_satpos_from_platform_name (incorrect import path).

@pnuu pnuu added this to the v0.60 milestone Nov 12, 2025
@pnuu pnuu self-assigned this Nov 12, 2025
@pnuu pnuu added the dependencies Pull requests that update a dependency file label Nov 12, 2025
@pnuu pnuu moved this to In Progress in Remote PCW Autumn 2025 Nov 12, 2025
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.33%. Comparing base (5666971) to head (ee989f6).
⚠️ Report is 42 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3294   +/-   ##
=======================================
  Coverage   96.32%   96.33%           
=======================================
  Files         463      463           
  Lines       58903    58870   -33     
=======================================
- Hits        56737    56711   -26     
+ Misses       2166     2159    -7     
Flag Coverage Δ
behaviourtests 3.60% <33.33%> (-0.01%) ⬇️
unittests 96.42% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

coveralls commented Nov 12, 2025

Pull Request Test Coverage Report for Build 19301582517

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on drop-numpy-1.x-support at 96.393%

Totals Coverage Status
Change from base Build 19293346095: 96.4%
Covered Lines: 56542
Relevant Lines: 58658

💛 - Coveralls

@pnuu
Copy link
Member Author

pnuu commented Nov 12, 2025

Looks like removing the xfail_skyfield_unstable_numpy2 decorator reveals some incorrect imports and unnecessary TLE download. I'll see if I find a simple fix for those to be included in this PR.

@pnuu pnuu requested a review from sfinkens as a code owner November 19, 2025 19:24
@djhoese
Copy link
Member

djhoese commented Nov 19, 2025

Should this maybe have the backwards incompatible and enhancement labels added to it? I don't think "dependencies" alone will make it show up in the changelog.

@pnuu pnuu added enhancement code enhancements, features, improvements backwards-incompatibility Causes backwards incompatibility or introduces a deprecation labels Nov 19, 2025
@pnuu pnuu merged commit 24b72ba into pytroll:main Nov 19, 2025
18 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Remote PCW Autumn 2025 Nov 19, 2025
@pnuu pnuu deleted the drop-numpy-1.x-support branch November 19, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backwards-incompatibility Causes backwards incompatibility or introduces a deprecation dependencies Pull requests that update a dependency file enhancement code enhancements, features, improvements

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Drop numpy <2.0 support

4 participants