Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3294 +/- ##
=======================================
Coverage 96.32% 96.33%
=======================================
Files 463 463
Lines 58903 58870 -33
=======================================
- Hits 56737 56711 -26
+ Misses 2166 2159 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request Test Coverage Report for Build 19301582517Details
💛 - Coveralls |
Member
Author
|
Looks like removing the |
4 tasks
djhoese
requested changes
Nov 19, 2025
djhoese
approved these changes
Nov 19, 2025
Member
|
Should this maybe have the backwards incompatible and enhancement labels added to it? I don't think "dependencies" alone will make it show up in the changelog. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR drops Numpy 1.x support from Satpy.
There
arewere two functions insatpy.tests.utilsthatdodid checks for Skyfield and h5py and their Numpy 2 support whichmight need checkingwere removed. The removal of Skyfield also revealed a bug insatpy.utils._get_satpos_from_platform_name(incorrect import path).