Skip to content

Conversation

@djhoese
Copy link
Member

@djhoese djhoese commented Mar 24, 2023

These tests were originally fixed by @sfinkens in #2412, but it assumed that the related xarray PR (pydata/xarray#7551) would be included in the next xarray release (2023.3.0) but it wasn't so now the tests are failing again. This PR bumps the xarray version check.

  • Closes #xxxx
  • Tests added
  • Fully documented

@djhoese djhoese requested review from pnuu and sfinkens March 24, 2023 01:01
@djhoese djhoese requested a review from mraspaud as a code owner March 24, 2023 01:01
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #2422 (21541b5) into main (39f9de7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2422   +/-   ##
=======================================
  Coverage   94.74%   94.74%           
=======================================
  Files         329      329           
  Lines       48880    48880           
=======================================
  Hits        46310    46310           
  Misses       2570     2570           
Flag Coverage Δ
behaviourtests 4.41% <ø> (-89.32%) ⬇️
unittests 95.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/tests/writer_tests/test_cf.py 99.60% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pnuu
Copy link
Member

pnuu commented Mar 24, 2023

LGTM

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud added the enhancement code enhancements, features, improvements label Mar 24, 2023
@mraspaud mraspaud merged commit b92fe9e into pytroll:main Mar 24, 2023
@djhoese djhoese deleted the bugfix-xarray-cf2 branch March 24, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:tests enhancement code enhancements, features, improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants