Add Cython as build dependency #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
cythonas build dependency. With it it's no longer necessary to runupdate_cpp.shmanually as cythonize is called automatically during the build, both for sdist and wheels. It also makes it easier to support new Python versions as those will only need a compatible cython version now. With no wheels on PyPI, the package will be build from scratch from thepyxfile.In theory
src/marisa_trie.cppcould be removed from source control as well now since it regenerated every time.This PR basically makes these changes redundant: "Rebuild Cython wrapper with Cython 3.x.x".