-
Notifications
You must be signed in to change notification settings - Fork 561
Add ragged paged attention #8659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bythew3i
reviewed
Jan 31, 2025
torch_xla/experimental/pallas_kernels/ragged_paged_attention_kernel.py
Outdated
Show resolved
Hide resolved
torch_xla/experimental/pallas_kernels/ragged_paged_attention_kernel.py
Outdated
Show resolved
Hide resolved
torch_xla/experimental/pallas_kernels/ragged_paged_attention_kernel.py
Outdated
Show resolved
Hide resolved
torch_xla/experimental/pallas_kernels/ragged_paged_attention_kernel.py
Outdated
Show resolved
Hide resolved
torch_xla/experimental/pallas_kernels/ragged_paged_attention_kernel.py
Outdated
Show resolved
Hide resolved
torch_xla/experimental/pallas_kernels/ragged_paged_attention_kernel.py
Outdated
Show resolved
Hide resolved
torch_xla/experimental/pallas_kernels/ragged_paged_attention_kernel.py
Outdated
Show resolved
Hide resolved
Contributor
How is 65536 calculated? |
Collaborator
Author
I found a ticket and someone uses it. I remember the number is the vmem limit on a TPU generation. |
ad2f87c to
9e4b227
Compare
bythew3i
approved these changes
Feb 1, 2025
…_extreme_one_tokens_per_sequence.
…added runtime check.
9e4b227 to
7fe5071
Compare
Collaborator
Author
|
|
miladm
approved these changes
Feb 3, 2025
Collaborator
|
cc onduty @lsy323 to assist with the CI test failure before we merge @vanbasten23 |
miladm
reviewed
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan:
cc: @miladm