Skip to content

fix saving versions on windows #8792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NicolasHug merged 10 commits into from
Feb 19, 2025
Merged

fix saving versions on windows #8792

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
65a08c7
fix saving versions on windows
bjarzemb Dec 9, 2024
33ee3d7
Update setup.py
bjarzemb Dec 9, 2024
0cdf697
Merge pull request #1 from pytorch/main
bjarzemb Jan 7, 2025
6a55101
Trigger CI
bjarzemb Jan 10, 2025
79a78fb
Merge branch 'main' into windows-fix
bjarzemb Jan 15, 2025
9ecdf3d
Merge branch 'main' into windows-fix
bjarzemb Jan 27, 2025
a4cf4f8
Merge branch 'main' into windows-fix
bjarzemb Feb 3, 2025
f56e04c
Merge branch 'main' into windows-fix
bjarzemb Feb 6, 2025
28f5c5b
Merge branch 'main' into windows-fix
NicolasHug Feb 19, 2025
6a51d03
Merge branch 'main' into windows-fix
NicolasHug Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def get_version():

def write_version_file(version, sha):
# Exists for BC, probably completely useless.
with open(ROOT_DIR / "torchvision/version.py", "w") as f:
with open(os.path.join(ROOT_DIR, "torchvision", "version.py"), "w") as f:
f.write(f"__version__ = '{version}'\n")
f.write(f"git_version = {repr(sha)}\n")
f.write("from torchvision.extension import _check_cuda_version\n")
Expand Down