tv_tensor -> TVTensor where it matters#7904
Merged
NicolasHug merged 5 commits intopytorch:mainfrom Aug 30, 2023
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7904
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New Failures, 2 Unrelated FailuresAs of commit da197bd with merge base d5f4cc3 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pmeier
reviewed
Aug 30, 2023
| with pytest.raises(ValueError, match="return_type must be"): | ||
| tv_tensors.set_return_type("typo") | ||
|
|
||
| tv_tensors.set_return_type("tensor") |
Contributor
There was a problem hiding this comment.
We do have a global setup teardown fixture to prevent any of this leaking, right? If so why set it to tensor and then do nothing with it?
Member
Author
There was a problem hiding this comment.
Yeah, we don't need it.
This follows up to #7828 (comment)
pmeier
approved these changes
Aug 30, 2023
Co-authored-by: Philip Meier <[email protected]>
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
Summary: (Note: this ignores all push blocking failures!) Reviewed By: matteobettini Differential Revision: D48900380 fbshipit-source-id: 61a93172f4911f2e0261d6bea2a481e7210c33e7 Co-authored-by: Philip Meier <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor cleanup following up to #7894 (comment)
This is mostly just renamings in the docs + in
set_return_type. Also added a minor test for input checks.