Skip to content

Cutmix -> CutMix#7784

Merged
NicolasHug merged 3 commits into
pytorch:mainfrom
NicolasHug:ljanflajnfljanfe
Aug 1, 2023
Merged

Cutmix -> CutMix#7784
NicolasHug merged 3 commits into
pytorch:mainfrom
NicolasHug:ljanflajnfljanfe

Conversation

@NicolasHug

@NicolasHug NicolasHug commented Aug 1, 2023 •
edited by pytorch-bot Bot
Loading

Copy link
Copy Markdown
Member

@pmeier @vfdev-5: discuss

Follow up to #7772 (comment)

(Note that timm names them Cutmix and Mixup)

cc @vfdev-5

@pytorch-bot

pytorch-bot Bot commented Aug 1, 2023 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7784

Note: Links to docs will display an error until the docs builds have been completed.

❌ 19 New Failures

As of commit b8d0030:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@vfdev-5

vfdev-5 commented Aug 1, 2023

Copy link
Copy Markdown
Contributor

@NicolasHug My comment was only about the documentation, class names can be Cutmix and Mixup

pmeier
pmeier approved these changes Aug 1, 2023
View reviewed changes

@pmeier pmeier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Nicolas

Comment thread torchvision/prototype/transforms/_augment.py


class _BaseMixupCutmix(_RandomApplyTransform):
class _BaseMixUpCutMix(_RandomApplyTransform):

@pmeier pmeier Aug 1, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we delete them from prototype now that we have a proper implementation in v2? If you do, note that there are tests for this in test/test_prototype_transforms.py

@NicolasHug NicolasHug Aug 1, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do in another PR

@NicolasHug NicolasHug merged commit 3e4e353 into pytorch:main Aug 1, 2023
This was referenced Aug 1, 2023
Merged
Merged
facebook-github-bot pushed a commit that referenced this pull request Aug 25, 2023
@NicolasHug @facebook-github-bot
[fbsync] Cutmix -> CutMix (#7784)
6fbb501 
Reviewed By: matteobettini

Differential Revision: D48642274

fbshipit-source-id: 2bf95841d5cc45d77e8def3e427d3386ae8e1148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@pmeier pmeier pmeier approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed code quality module: transforms

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NicolasHug @vfdev-5 @pmeier @facebook-github-bot